Skip to content

Conditionally unmapping mappings#80

Closed
minond wants to merge 1 commit into
wlangstroth:masterfrom
minond:master
Closed

Conditionally unmapping mappings#80
minond wants to merge 1 commit into
wlangstroth:masterfrom
minond:master

Conversation

@minond

@minond minond commented Mar 29, 2023

Copy link
Copy Markdown

Conditionally unmapping nmap <buffer> K and nmap <buffer> K which are conditionally mapped in the first place (when no previous mapping exists.)

@minond

minond commented Mar 29, 2023

Copy link
Copy Markdown
Author

I'm just seeing #79 -- closing this PR in favor of that one. Any technical reason that PR hasn't been merged yet though? In any case, thanks for the great plugin!

@minond minond closed this Mar 29, 2023
@benknoble

Copy link
Copy Markdown
Contributor

I'm just seeing #79 -- closing this PR in favor of that one. Any technical reason that PR hasn't been merged yet though? In any case, thanks for the great plugin!

I can't answer for @wlangstroth , but I haven't seen a lot of activity here. The files that ship with Vim come from my fork https://github.com/benknoble/vim-racket, which already has a similar fix using silent!.

@minond

minond commented Mar 29, 2023

Copy link
Copy Markdown
Author

Hey @benknoble, thanks for the reply. That's awesome, I've switched over to your fork.

@wlangstroth

Copy link
Copy Markdown
Owner

You absolutely should use @benknoble 's fork. Pass it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants