Open
Conversation
…lling services and improved the flow based on cert-manager and calling services requirement
…ory, how to verify, download artifact, and documentation around cert-manager and calling components
…o kernel requirements
arthurwolf
reviewed
Apr 13, 2026
arthurwolf
reviewed
Apr 13, 2026
| fi | ||
|
|
||
| # Setting coturn node IP values | ||
| yq eval -i ".coturnTurnListenIP = \"$CALLING_NODE_IP\"" "$BASE_DIR/values/coturn/values.yaml" |
Contributor
There was a problem hiding this comment.
This is a problem that predates the PR, but I thought I'd still mention: almost all value modifications use a temporary file pattern, like:
yq eval -i '.tls.issuerRef.name = "letsencrypt-http01"' "$TEMP_DIR/sftd-values.yaml"just above...
But these edit the files "directly" without going through a temp file, which means no "Updating..." log messages like other edits have, no idempotency check, more risk etc.
Minor but thought I'd point it out.
Contributor
Author
There was a problem hiding this comment.
yes, let me patch it
arthurwolf
reviewed
Apr 13, 2026
arthurwolf
reviewed
Apr 13, 2026
arthurwolf
reviewed
Apr 13, 2026
arthurwolf
reviewed
Apr 13, 2026
Co-authored-by: Arthur Wolf <wolf.arthur@gmail.com>
|
arthurwolf
approved these changes
Apr 17, 2026
Contributor
arthurwolf
left a comment
arthurwolf
left a comment
There was a problem hiding this comment.
Looks all good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Basic information
Testing
Offline Build CI (label-based)
Add one or more labels to trigger offline builds:
build-default- Full production build (ansible, terraform, all packages)build-dev- WIAB/dev buildbuild-wiab-staging- WIAB-staging buildbuild-min- Minimal build (fastest, essential charts only)build-all- Run all three buildsNote: No builds run by default. Add a label to trigger CI.
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case