feat: folder-grouped tabular reviews with per-user page limit#54
Open
ecarjat wants to merge 1 commit intowillchen96:mainfrom
Open
feat: folder-grouped tabular reviews with per-user page limit#54ecarjat wants to merge 1 commit intowillchen96:mainfrom
ecarjat wants to merge 1 commit intowillchen96:mainfrom
Conversation
Adds the ability to treat all documents within the same project
subfolder as a single tabular review row, plus a per-user configurable
page limit for grouped rows with clear error reporting.
**Folder-grouped rows**
- New `document_grouping` column on `tabular_reviews` (`document` | `folder`)
- New `tabular_review_rows` and `tabular_review_row_sources` tables replace
the implicit per-document model; every row carries an explicit source list
- Backfill migration moves existing cell data into the new row model
- Frontend toggle ("treat subfolder documents as one row") in the
Add Review modal and side panel
- Row label shows folder path with document count subtitle
**Per-user page limit**
- `tabular_max_pages` column on `user_profiles` (10–2000, default 250)
- Setting exposed in Account → Models & API Keys
- Rows exceeding the limit are skipped with a single row-level error
banner (instead of per-cell error icons)
- Error cells now show a tooltip with the failure reason
**PDF.js fixes**
- Pass `standardFontDataUrl` and `verbosity: 0` to all `getDocument`
calls to eliminate `standardFontDataUrl` and `TT: undefined function`
console warnings
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tabular_max_pagessetting (10–2000, default 250) in Account → Models & API Keys controls how large a grouped row can be before it is skipped. Rows that exceed the limit now surface a single, full-width error banner instead of repeating the error icon in every column.getDocumentcalls now passstandardFontDataUrlandverbosity: 0, eliminating thestandardFontDataUrlandTT: undefined function: 32console warnings.Database changes
Two new migrations ship alongside an updated
schema.sql:20260510000000_tabular_review_rows.sqldocument_groupingtotabular_reviews; introducestabular_review_rowsandtabular_review_row_sourcestables; backfills existing cells; adds RLS policies20260510000001_user_tabular_max_pages.sqltabular_max_pages integer default 250touser_profilesThe initial schema (
20240101000000_initial_schema.sql) is also updated to keep it in sync with the new tables for fresh installs.Test plan
standardFontDataUrlorTT: undefined functionwarnings in backend logs after PDF upload/processing🤖 Generated with Claude Code