Fix JarFile leak in PackageScanner#getClasses#1415
Open
iamsanjaymalakar wants to merge 1 commit intowicketstuff:masterfrom
Open
Fix JarFile leak in PackageScanner#getClasses#1415iamsanjaymalakar wants to merge 1 commit intowicketstuff:masterfrom
iamsanjaymalakar wants to merge 1 commit intowicketstuff:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PackageScanner#getClasses()opens JarFile instances when scanning "jar"/"wsjar" resources but never closes them. If scanning or class loading throws, the opened JARs are also left unclosed.Fix
Close all opened JarFiles in a finally block. The cleanup continues closing remaining JARs even if one close fails, and rethrows the first IOException with subsequent failures added as suppressed exceptions.