fix(piebald): progress accounting, fork validation, generic CLI help#480
Merged
Conversation
The list went stale every time a new agent was added (most recently Piebald). Replace with a generic description; the supported-agents table in README.md and the per-agent env vars below stay authoritative.
- Keep stats.messagesIndexed in sync with dbProgress.MessagesIndexed inside advanceDBProgress so the terminal PhaseDone reports the cumulative count instead of regressing to the file-only total. - Verify the requested Piebald session exists in the parsed results before treating a base-chat lookup as a hit in syncSinglePiebald, FindSource, and SourceMtime. Stale or typoed fork IDs like "piebald:42-999" now fail closed instead of silently succeeding.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes to #478 surfaced by post-merge review:
stats.messagesIndexedwas tracking only the file-backed total, so the terminalPhaseDonecallback regressedMessagesIndexedto the file-only count after Piebald/OpenCode/Warp/Forge work. Now updated insideadvanceDBProgressso the cumulative count holds.syncSinglePiebald,FindSource, andSourceMtimestrip the-<row>suffix from fork IDs to look up the base chat, but didn't verify the requested fork actually exists. Stale or typoed IDs likepiebald:42-999could silently succeed or return mtimes for non-existent sessions. They now require an exactSession.IDmatch in the parsed results.agentsview --help. The list went stale every time a new agent was added (most recently Piebald); the README's supported-agents table and per-agent env vars below stay authoritative.