Add WebIDL and descriptions to spec draft#75
Conversation
beaufortfrancois
left a comment
beaufortfrancois
left a comment
There was a problem hiding this comment.
Thanks for starting this Brandon!
index.bs
Outdated
|
|
||
| <dt><dfn method for="ModelContext">registerTool(tool)</dfn></dt> | ||
| <dd> | ||
| Registers a single tool without clearing the existing set of tools. If a tool with the same name already exists, the method throws an Error. |
There was a problem hiding this comment.
It will also raise an error in the following cases:
- tool name is missing
- description is missing
- input schema is invalid
There was a problem hiding this comment.
Thanks. I'll mention an error being thrown for input schema invalid. I would expect a TypeError on missing tool name or description is implied by the required keyword for these properties on ModelContextTool.
index.bs
Outdated
| boolean readOnly; | ||
| }; | ||
|
|
||
| callback ToolExecuteCallback = ToolResponse (object input, ModelContextClient client); |
There was a problem hiding this comment.
FYI Chromium currently defines this as Promise<any>(any... parameters);.
There was a problem hiding this comment.
Updated the return Promise to any. I'm keeping the parameters as-is since I think these are the current consensus, even if client (used for elicitation) isn't implemented in Chromium yet.
This commit resolves the #75 (comment) review comment, and also adds the domintro box for `clearContext()`, resolving #75 (comment). This commit also removes unnecessary dictionary member re-definitions, resolving #75 (comment).
domfarolino
force-pushed
the
spec-draft-webidl
branch
from
8494474 to
98b1ba3
Compare
|
I rebased this PR on top of |
anssiko
left a comment
anssiko
left a comment
There was a problem hiding this comment.
Thank you for this baseline. We can adddress the TODOs in separate PRs.
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
Agreed, we'll land this now and follow-up with changes as necessary.
4 participants
An initial pass at WebIDL for the current proposed API, and short descriptions of each property/method.
Preview | Diff