Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR shortens the Agent Modality FTUE callout flow and bypasses the session config modal before starting the tutorial. The state-machine reduction is generally aligned with the intended two-step flow, and I did not find security concerns in the changed code paths.
Concerns
- The disabled-NLD first callout no longer explains that natural language detection is off by default or what enabling the checkbox does.
- The project final callout no longer tells users that Esc returns them to terminal mode, even though the flow still supports that shortcut and the spec requires it.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
Looks good to me pending the discussion in slack
| title: "Updated agent input", | ||
| text: "Your agent input will detect natural language as well as commands by default. Use ! to lock the input in bash mode to write commands.\n\nSubmit the query below to have the agent initialize this project, or ⊗ to clear the input and start your own!".to_string(), | ||
| step: StepStatus::new(3, total_steps), | ||
| title: "You're in agent mode", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Overview
This PR reduces the Agent Modality FTUE flow from four callouts to two, bypasses the FTUE session config modal, and adds product/tech specs for the behavior.
Concerns
- The project-path final agent-mode callout omits the Escape/return-to-terminal instruction even though the callout still handles that shortcut and the spec requires teaching it.
- Supplemental security pass found no security-specific issues.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| text: "Your agent input will detect natural language as well as commands by default. Use ! to lock the input in bash mode to write commands.\n\nSubmit the query below to have the agent initialize this project, or ⊗ to clear the input and start your own!".to_string(), | ||
| step: StepStatus::new(3, total_steps), | ||
| title: "You're in agent mode", | ||
| text: "Agent mode gives your questions and tasks their own conversation, so you can ask follow-ups without leaving your terminal workflow.\n\nSubmit the query below to have the agent initialize this project, or ⊗ to clear the input and start your own!".to_string(), |
There was a problem hiding this comment.
BackToTerminal and the spec requires teaching ESC; include keybindings.return_to_terminal_mode here as in the no-project branch.
2 participants
We're simplifying the FTUE modality callouts from 4 steps to 2, and also removing the tab config tutorial modal.
Demo: https://www.loom.com/share/6551cd1350324105a7b394460507f637
Discussion: https://warpdev.slack.com/archives/C08KTPNQN65/p1778683523252269
Closes #11107