Centralize build feature profiles in Cargo metadata#11103
Conversation
|
This PR is not linked to an issue that is marked with Issue-state enforcement details:
Readiness check:
To continue, link this PR to a same-repo issue such as Powered by Oz |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: #10979
-
Required readiness label:
ready-to-implement
Readiness check:
- #10979: missing
ready-to-implement; readiness labels present: none
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
Summary
Fixes #10979.
This centralizes the Cargo feature matrix in
app/Cargo.tomlso the bundle scripts and Nix package resolve named build profiles from the same metadata instead of keeping their own stale feature lists.package.metadata.warp.build_feature_groupsandpackage.metadata.warp.build_profilesflake.nixto read the Nix build profile from Cargo metadatascript/check_cargo_build_profilesto validate the declared profile matrixagent_mode_debug, while macOS preview stays off heap diagnosticsValidation
script/check_cargo_build_profiles --profile windows.local.appscript/check_cargo_build_profiles --profile macos.preview.appscript/check_cargo_build_profiles --profile macos.preview.cliscript/check_cargo_build_profiles --allcargo metadata --format-version 1 --no-deps --locked --no-default-features --features "$features" --manifest-path app/Cargo.tomlfor every declared profilenix eval .#warp-terminal-experimental.buildFeatures --jsonnix eval --impure --expr 'let app = builtins.fromTOML (builtins.readFile ./app/Cargo.toml); in app.package.metadata.warp.nix.build_profile' --rawnix build .#warp-terminal-experimental --no-link --print-out-pathsbash -n script/cargo_bundle_features.sh script/check_cargo_build_profiles script/deploy_remote_server script/deploy_remote_server_to_test_vm script/linux/bundle script/macos/bundle script/run script/wasm/bundlegit diff --check