Clip terminal view column to prevent split-pane footer overflow

[SagarSDagdu]

Description

TerminalView::render's main column wraps the output area in Shrinkable but adds the input area without any flex/clip. In a Flex column, non-flex children are laid out with an unbounded main-axis constraint and take their natural height, so when a horizontal split shortens the top pane the input box + chip rows + footer can overflow past the column's bottom edge and paint into the pane below.

This PR wraps the column in Clipped at the outer Stack. The Flex column reports the max-constraint height (because of MainAxisSize::Max), so the clip rect matches the pane's available height. Sibling overlays in the same Stack (context menus, tooltips, ambient-agent progress, etc.) are added after column.finish() and remain outside the clip layer, so they're unaffected. The cloud-mode-v2 composing branch directly above already uses Expanded (FlexFit::Tight) and shrinks correctly, so it doesn't need this wrapper.

This is the vertical analog of #10724 / #10811 (horizontal overflow on the inline-menu header) and applies the same Clipped-at-the-overflow-source pattern.

Linked Issue

Fixes #10906

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Screenshots / Videos

Before

Screen.Recording.2026-05-16.at.12.09.33.PM.mov

After

Screen.Recording.2026-05-16.at.12.10.26.PM.mov

Testing

• I have manually tested my changes locally with ./script/run.

Reproduction:

1. Open Warp and enter agent input mode with enough chips/attachments that the input footer has multiple rows.
2. Cmd+Shift+D to split the window horizontally.
3. Drag the divider up until the top pane is short.
4. Confirm the footer's bottom row clips at the divider instead of bleeding into the lower pane.

Also spot-checked:

• Normal-height pane: input + output still render as before.
• Output area still expands to fill available space when the pane is tall.
• Context menus, tooltips, and ambient-agent progress (sibling overlays in the outer Stack) are unaffected by the clip.

cargo check -p warp is clean.

No automated test added — the fix is a single Clipped wrapper and is most cheaply verified by manual repro in a short horizontally-split pane.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

[oz-for-oss]

@SagarSDagdu

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR wraps the normal TerminalView::render column in Clipped so a short split pane constrains the terminal output/input column to the pane bounds while leaving later stack overlays outside the clip layer. The change is localized, matches the existing clipping pattern already used elsewhere in terminal rendering, and the PR includes visual before/after evidence plus manual validation.

Concerns

• None.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz