[REMOTE-1709] Back off harness auth secret fetch retries#11089
Open
abhishekp106 wants to merge 2 commits into
Open
[REMOTE-1709] Back off harness auth secret fetch retries#11089abhishekp106 wants to merge 2 commits into
abhishekp106 wants to merge 2 commits into
Conversation
Use the shared out-of-band retry strategy when fetching harness auth secrets and keep the model in Loading while bounded retries are pending. After final failure, apply a short cooldown before ensure_auth_secrets_fetched can start another retry chain, preventing subscriber repopulation loops from spamming requests while the server is down. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds retry/backoff handling around harness auth secret fetches and keeps the UI in a loading state while retry attempts are pending.
Concerns
- The retry predicate used for this GraphQL request does not classify GraphQL HTTP/status errors, so permanent failures such as 401/403/404 or user-facing GraphQL errors still burn through the retry chain and then enter the cooldown instead of failing fast.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Use a GraphQL-aware transient error classifier for harness auth-secret fetch retries so permanent GraphQL statuses and user-facing errors fail without consuming the retry chain. Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Abhishek Pandya <40919306+abhishekp106@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
list_harness_auth_secrets.Loadingwhile retry attempts are pending, avoiding intermediate failure events.Linked Issue
REMOTE-1709
Testing
cargo fmt -- app/src/ai/harness_availability.rscargo check -p warpcargo clippy -p warp --all-targetsI have manually tested my changes locally with
./script/runworks locally without spamming the server anymore!
Agent Mode
CHANGELOG-NONE
This PR was created by Oz (running Codex).