doc: add global maxRetry option#3846
Conversation
e3e0a56 to
6b387bd
Compare
|
/lgtm |
|
Hi @hwdef When will volcano/apis be released? Use new apis version to generate new CRD. |
|
sorry I do not know about this. |
Can you tell me which CRD are you going to use? |
|
|
/lgtm cancel |
|
I prefer the following definition type Flow struct {
// +kubebuilder:validation:MinLength=1
// +required
Name string `json:"name"`
// +optional
DependsOn *DependsOn `json:"dependsOn,omitempty"`
// +optional
MaxRetry *MaxRetry `json:"maxRetry,omitempty"`
} |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
I agree. Change it to design done. |
|
@googs1025 |
I'm ok with this. |
|
I think we should squash commit to one |
cd69649 to
f8bf78d
Compare
Thanks @googs1025 @hwdef |
f8bf78d to
9cf918d
Compare
|
@hwdef Please add label to merge it, thanks |
9cf918d to
fb6f737
Compare
fb6f737 to
21856b4
Compare
f8bf78d to
c54d7e7
Compare
|
cc @Monokaix @googs1025 PTAL, recheck it |
c54d7e7 to
43b88d4
Compare
Signed-off-by: dongjiang <dongjiang1989@126.com>
43b88d4 to
81af690
Compare
| * `if` statements | ||
| * `switch` statements | ||
| * `for` statements | ||
| * Support job failure retry in JobFlow |
There was a problem hiding this comment.
We should also implement this in controller first?
There was a problem hiding this comment.
The next PR to add this feature.
This PR to patch MaxRetry from jobflow to jobTemplate
add global jobRetry option
ref: #3838