Skip to content

doc: add global maxRetry option#3846

Open
dongjiang1989 wants to merge 1 commit into
volcano-sh:masterfrom
dongjiang1989:add-jobflow-retry-doc
Open

doc: add global maxRetry option#3846
dongjiang1989 wants to merge 1 commit into
volcano-sh:masterfrom
dongjiang1989:add-jobflow-retry-doc

Conversation

@dongjiang1989

@dongjiang1989 dongjiang1989 commented Nov 27, 2024

Copy link
Copy Markdown
Member

add global jobRetry option

ref: #3838

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2024
Comment thread docs/design/jobflow/README.md Outdated
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2024
@dongjiang1989 dongjiang1989 changed the title doc: add global jobRetry option doc: add global maxRetry option Nov 28, 2024
Comment thread example/jobflow/JobFlow.yaml Outdated
@hwdef

hwdef commented Nov 29, 2024

Copy link
Copy Markdown
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
@dongjiang1989

Copy link
Copy Markdown
Member Author

Hi @hwdef When will volcano/apis be released? Use new apis version to generate new CRD.

@hwdef

hwdef commented Nov 29, 2024

Copy link
Copy Markdown
Member

sorry I do not know about this.
Please ask @Monokaix

@Monokaix

Copy link
Copy Markdown
Member

Hi @hwdef When will volcano/apis be released? Use new apis version to generate new CRD.

Can you tell me which CRD are you going to use?

@dongjiang1989

Copy link
Copy Markdown
Member Author

Hi @hwdef When will volcano/apis be released? Use new apis version to generate new CRD.

Can you tell me which CRD are you going to use?

ref:volcano-sh/apis#145

@hwdef

hwdef commented Dec 2, 2024

Copy link
Copy Markdown
Member

/lgtm cancel

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@hwdef

hwdef commented Dec 2, 2024

Copy link
Copy Markdown
Member

I prefer the following definition

type Flow struct {
	// +kubebuilder:validation:MinLength=1
	// +required
	Name string `json:"name"`
	// +optional
	DependsOn *DependsOn `json:"dependsOn,omitempty"`
	// +optional
	MaxRetry *MaxRetry `json:"maxRetry,omitempty"`
}

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hwdef
You can assign the PR to them by writing /assign @hwdef in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2024
@dongjiang1989

Copy link
Copy Markdown
Member Author

I prefer the following definition

type Flow struct {
	// +kubebuilder:validation:MinLength=1
	// +required
	Name string `json:"name"`
	// +optional
	DependsOn *DependsOn `json:"dependsOn,omitempty"`
	// +optional
	MaxRetry *MaxRetry `json:"maxRetry,omitempty"`
}

I agree. Change it to design done.
Thanks @hwdef

@hwdef

hwdef commented Dec 3, 2024

Copy link
Copy Markdown
Member

@googs1025
What do you think of this?

@googs1025

Copy link
Copy Markdown
Member

@googs1025 What do you think of this?

I'm ok with this.

@googs1025

Copy link
Copy Markdown
Member

I think we should squash commit to one

@dongjiang1989 dongjiang1989 force-pushed the add-jobflow-retry-doc branch 2 times, most recently from cd69649 to f8bf78d Compare December 5, 2024 06:47
@dongjiang1989

Copy link
Copy Markdown
Member Author

I think we should squash commit to one

Thanks @googs1025 @hwdef
Squash commits done.
Please re-check it.

@dongjiang1989

Copy link
Copy Markdown
Member Author

@hwdef Please add label to merge it, thanks

@dongjiang1989 dongjiang1989 force-pushed the add-jobflow-retry-doc branch from fb6f737 to 21856b4 Compare January 9, 2025 11:45
@dongjiang1989 dongjiang1989 force-pushed the add-jobflow-retry-doc branch 3 times, most recently from f8bf78d to c54d7e7 Compare March 14, 2025 07:07
@dongjiang1989

Copy link
Copy Markdown
Member Author

cc @Monokaix @googs1025 PTAL, recheck it

@hwdef hwdef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Mar 14, 2025
@dongjiang1989 dongjiang1989 force-pushed the add-jobflow-retry-doc branch from c54d7e7 to 43b88d4 Compare March 17, 2025 06:42
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025

@hwdef hwdef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@dongjiang1989 dongjiang1989 reopened this Mar 17, 2025
Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 force-pushed the add-jobflow-retry-doc branch from 43b88d4 to 81af690 Compare March 18, 2025 06:23
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025

@hwdef hwdef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2025
* `if` statements
* `switch` statements
* `for` statements
* Support job failure retry in JobFlow

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also implement this in controller first?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next PR to add this feature.

This PR to patch MaxRetry from jobflow to jobTemplate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants