update cooldown protection plugin and supports the protection of the maximum number of cooldown. #2363
Conversation
…port，issue:#7 Signed-off-by: 刘毅（Jason Liu） <liuyi03@qiyi.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/L
Thor-wl
requested review from
Thor-wl,
hwdef,
qiankunli,
shinytang6 and
wpeng102
and removed request for
huone1,
hzxuzhonghu and
k82cn
|
/cc @flyhighzy Please help take a review, too. Thanks! |
| // Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h". | ||
| const CooldownTime = "volcano.sh/cooldown-time" | ||
|
|
||
| // MaxCooldownTimes is the annotation key of Pod to set maximum number of cooldown(evictions), |
There was a problem hiding this comment.
Do not modify the files under vendor directly.
There was a problem hiding this comment.
that's my fault, let us discourse and decide to add this label in apis volcano-sh/apis#84 repo.
Signed-off-by: 刘毅（Jason Liu） <liuyi03@qiyi.com>
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
lifecycle/stale
4 participants
as issue #2149 describes, now cdp plugin supports the protection of the maximum number of cooldown.
issue: #2362 provide a new label/annotation named "volcano.sh/max-cooldown-times", whose value means the max number of cooldown(eviction times) for entire job or dedicated task. if the task cooldown times are greater than this value, the task cannot be evicted.
update
cdpplugin to participate in preempting action, and ensure pods that belong to protected tasks will be not in the result victims list.