add a label key: TaskIndexKey = volcano.sh/task-index

[shuaiyy]

the task pod has a label of task spec by TaskSpecKey = "volcano.sh/task-spec",
while task index missed, it's useful for pod lbael selectors to select a task pod by it's spec and index

the issue is here: add label key volcano.sh/task-index #98

[volcano-sh-bot]

Welcome @shuaiyy!

It looks like this is your first PR to volcano-sh/apis 馃帀.

Thank you, and welcome to Volcano. 😃

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hwdef]

I don't quite understand this requirement. Do you have a more detailed explanation? Is there any place where this field is used?

[shuaiyy]

I don't quite understand this requirement. Do you have a more detailed explanation? Is there any place where this field is used?

I have updated the description.

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

[Thor-wl]

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

Can you provide the original requirement? Yes, this key has been added into the environment variables.

[shuaiyy]

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

Can you provide the original requirement? Yes, this key has been added into the environment variables.

Okay. I'm trying to use volcano to replace kubeflow training-operator in my ml-platform; the training-operator provide job-name|task-spec|task-index label in task pod, while volcano missed task-index.

our ml-platform need these label：

1. mount env key TASK_INDEX, the key is used by users and it's hard to let them change to VC_TASK_INDEX
2. create a service with pod selector for a spectific task pod, and then create an ingress; if users need to debug their task by http tools;
3. watch task pod's change and sync some info to persist db.

in our scenes, the use of task-index label may not common to other volcano users, but I do think the pod label info task-index is common, should be provided no matter how users will use it

[hanjialeOK]

task-index info will be set to task pod's label, it has been set to container env key VC_TASK_INDEX by env plugin, but missed in pod labels.

Can you provide the original requirement? Yes, this key has been added into the environment variables.

Okay. I'm trying to use volcano to replace kubeflow training-operator in my ml-platform; the training-operator provide job-name|task-spec|task-index label in task pod, while volcano missed task-index.

our ml-platform need these label：

1. mount env key TASK_INDEX, the key is used by users and it's hard to let them change to VC_TASK_INDEX
2. create a service with pod selector for a spectific task pod, and then create an ingress; if users need to debug their task by http tools;
3. watch task pod's change and sync some info to persist db.

in our scenes, the use of task-index label may not common to other volcano users, but I do think the pod label info task-index is common, should be provided no matter how users will use it

Totally agree with your point! It's incredible that our requirements are almost exactly the same! Our ml-platform is also planning to migrate from training-operator to volcanojob in order to better support multi-role distributed jobs. Like you, our code debugging service also needs to create a separate Service for each Pod.

The training-operator includes a task-index in the Pod labels, which perfectly fits our needs. Unfortunately, volcanojob does not provide this task-index label.

[volcano-sh-bot]

@shuaiyy: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hzxuzhonghu]

this requirement makes sense for me @shuaiyy would you want to resolve the conficts, then we can get it merged