add v1 api version#81
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
70a302d to
d7d3b1e
Compare
|
@lucming Have you combine this PR with the master branch of volcano.sh/volcano and take a fully UT and e2e test locally? |
Thor-wl
left a comment
There was a problem hiding this comment.
It generally LGTM to me. Please mind the compatibility for users who are still making use of low versions.
hwdef
left a comment
There was a problem hiding this comment.
By the way, don't understand the meaning of bus, should we change it to a more understandable word
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| Copyright 2021 The Volcano Authors. | |||
There was a problem hiding this comment.
| Copyright 2021 The Volcano Authors. | |
| Copyright 2022 The Volcano Authors. |
| @@ -0,0 +1,46 @@ | |||
| /* | |||
| Copyright 2021 The Volcano Authors. | |||
There was a problem hiding this comment.
| Copyright 2021 The Volcano Authors. | |
| Copyright 2022 The Volcano Authors. |
en,volcano.sh/volcano this project changed too much,i want check more,and i will make a pr latter |
okay,i will pay more attention to it,thanks. |
I'm also very confused about this,can you tell me what he wants to say? |
I also don't know what this means, may need to consult other more senior maintainers |
844631e to
fdd33d9
Compare
|
i find https://github.com/volcano-sh/apis/blob/master/pkg/apis/helpers/helpers.go this file in this project,most of them are ways to operate basic resource in k8s,it seems more reasonable to move this file to volcan.sh/volcano |
|
/hold |
|
@lucming, It's great to have this pr to upgrade api version. Thank you so much. |
I have written a version of the code to upgrade the volcano api version, but there are other things were delayed so have not mentioned pr. |
Signed-off-by: lucming <2876757716@qq.com>
fdd33d9 to
062ae57
Compare
|
@lucming: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
volcano-sh/volcano#2201