Skip to content

Add SchedulerPolicy in queueSpec#176

Open
TriangleWuYQ wants to merge 1 commit into
volcano-sh:masterfrom
TriangleWuYQ:master
Open

Add SchedulerPolicy in queueSpec#176
TriangleWuYQ wants to merge 1 commit into
volcano-sh:masterfrom
TriangleWuYQ:master

Conversation

@TriangleWuYQ

Copy link
Copy Markdown

Add SchedulerPolicy in queueSpec.
Related issue: volcano-sh/volcano#3992
Related design doc: volcano-sh/volcano#4163

@volcano-sh-bot volcano-sh-bot requested review from Thor-wl and k82cn April 28, 2025 08:04
@volcano-sh-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread pkg/apis/scheduling/types.go Outdated

// SchedulerPolicy define the scheduling policy of queue
// +optional
SchedulerPolicy string `json:"schedulerPolicy,omitempty" protobuf:"bytes,11,opt,name=schedulerPolicy"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SchedulerPolicy string `json:"schedulerPolicy,omitempty" protobuf:"bytes,11,opt,name=schedulerPolicy"`
SchedulingPolicy string `json:"schedulerPolicy,omitempty" protobuf:"bytes,11,opt,name=schedulingPolicy"`

Priority int32 `json:"priority,omitempty" protobuf:"bytes,10,opt,name=priority"`

// SchedulerPolicy define the scheduling policy of queue
// +optional

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same above.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Yuqi Wu <wuyuqi22@mails.ucas.ac.cn>
@volcano-sh-bot

Copy link
Copy Markdown
Collaborator

@ElectricFish7: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants