Skip to content

feat: add podgroup unenqueueable condition type and un-enqueueable reason#113

Open
lowang-bh wants to merge 1 commit into
volcano-sh:masterfrom
lowang-bh:add_uninqueue_state
Open

feat: add podgroup unenqueueable condition type and un-enqueueable reason#113
lowang-bh wants to merge 1 commit into
volcano-sh:masterfrom
lowang-bh:add_uninqueue_state

Conversation

@lowang-bh

@lowang-bh lowang-bh commented Aug 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@lowang-bh lowang-bh mentioned this pull request Aug 12, 2023
Open
@lowang-bh

lowang-bh commented Aug 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@Thor-wl @hwdef @wangyang0616 Please help to review and merge it before volcano's relative PR.

Thor-wl
Thor-wl reviewed Aug 16, 2023
View reviewed changes

@Thor-wl Thor-wl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask about the requirement and scenario of this PR? Suggest to add descriptions about that.

@lowang-bh

lowang-bh commented Aug 20, 2023

Copy link
Copy Markdown
Member Author

May I ask about the requirement and scenario of this PR? Suggest to add descriptions about that.

Hi, @Thor-wl docs added at volcano-sh/volcano#3065

@lowang-bh

lowang-bh commented Sep 12, 2023

Copy link
Copy Markdown
Member Author

/assign @william-wang @Thor-wl

william-wang
william-wang reviewed Sep 15, 2023
View reviewed changes
Comment thread pkg/apis/scheduling/types.go Outdated
william-wang
william-wang reviewed Sep 15, 2023
View reviewed changes
Comment thread pkg/apis/scheduling/types.go Outdated
william-wang
william-wang reviewed Sep 15, 2023
View reviewed changes
Comment thread pkg/apis/scheduling/v1beta1/types.go Outdated
william-wang
william-wang reviewed Sep 15, 2023
View reviewed changes
Comment thread pkg/apis/scheduling/types.go
@lowang-bh

lowang-bh commented Nov 16, 2023

Copy link
Copy Markdown
Member Author

Hi, @william-wang , any update here?

@Monokaix

Monokaix commented Nov 17, 2023

Copy link
Copy Markdown
Member

Hi, please update code geneate.

@lowang-bh

lowang-bh commented Nov 20, 2023

Copy link
Copy Markdown
Member Author

Hi, please update code geneate.

There is no changes after running bash ./hack/update-codegen.sh.

@william-wang william-wang changed the title feat: add podgroup uninqueueable condition type and un-enqueueable reason feat: add podgroup unenqueueable condition type and un-enqueueable reason Dec 14, 2023
william-wang
william-wang reviewed Dec 14, 2023
View reviewed changes
Comment thread pkg/apis/scheduling/v1beta1/types.go
@Monokaix

Monokaix commented Mar 27, 2024

Copy link
Copy Markdown
Member

/lgtm

@lowang-bh lowang-bh force-pushed the add_uninqueue_state branch from 941bf2d to 97a8fb9 Compare July 26, 2024 13:24
@lowang-bh lowang-bh force-pushed the add_uninqueue_state branch from cf31b32 to 74ae85d Compare October 26, 2024 06:23
@volcano-sh-bot

volcano-sh-bot commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hwdef

hwdef commented Oct 28, 2024

Copy link
Copy Markdown
Member

/lgtm

@lowang-bh
feat: add podgroup uninqueueable condition type and un-enqueueable re…
9fcb269 
…ason

Signed-off-by: lowang-bh <lhui_wang@163.com>
@hwdef

hwdef commented Jan 6, 2025

Copy link
Copy Markdown
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-wang william-wang william-wang left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

+1 more reviewer

@Thor-wl Thor-wl Thor-wl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@william-wang william-wang

@hwdef hwdef

@Monokaix Monokaix

@Thor-wl Thor-wl

Labels

lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lowang-bh @Monokaix @volcano-sh-bot @hwdef @william-wang @Thor-wl