fix(cli): preserve single-segment project path in updateWorkspaceConfig#1582
Merged
fengmk2 merged 2 commits intoMay 15, 2026
Merged
Conversation
path.dirname returns '.' for single-segment paths like 'website', which made the previous truthiness check fall through to the '/*' branch and emit './*' instead of the intended literal pattern. Handle '.' explicitly so a project at the repo root keeps its name as the workspace pattern. Adds unit coverage for updateWorkspaceConfig pattern derivation, discoverWorkspacePackages, updatePackageJsonWithDeps, and findPackageJsonFilesFromPatterns — none of which had tests before.
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
|
@fengmk2 Could you please re-run the CI for this PR? |
fengmk2
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp create --directory websitewas writingpackages: [ ./* ]topnpm-workspace.yamlinstead ofpackages: [ website ]. Fix the pattern-derivation so single-segment paths stay literal.Cause
path.dirname('website')returns'.', not''.'.'is truthy, so the literal branch never fired — every single-segment path became./*.The fix:
./*over-matches in pnpm (picks up every root sibling with apackage.json) and accumulates on repeat calls becauseminimatch('name', './*')returns false, so the skip-when-matched guard misses it.