Open
Conversation
✅ Deploy Preview for splinterdb canceled.
|
scober
force-pushed
the
scb/fallocate-fix
branch
3 times, most recently
from
f0a1a16 to
bc2636f
Compare
EOPNOTSUPP needs to be compared to errno, not the fallocate return value. Along the way, define a constant for the superblock size because it gets used a lot in that section. Signed-off-by: Simon Bertron <sb2684@cornell.edu>
scober
force-pushed
the
scb/fallocate-fix
branch
from
bc2636f to
4ae4864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EOPNOTSUPP needs to be compared to errno, not the fallocate return value. Along the way, define a constant for the superblock size because it gets used a lot in that section.