add option for extra HTTP headers containing checksums#211
add option for extra HTTP headers containing checksums#211yol wants to merge 1 commit intovideolabs:masterfrom
Conversation
adds an rfc1864 compatible content-md5 header and analog extensions for sha1 and sha256 if the option CheckSumHeaders is true the following extra http headers will be added: Content-Md5: I9rjdRkQr90tbzCzZtDy4A== Content-Sha1: kvbBunf6Il0/5oMcuItvYcaHN9c= Content-Sha256: ktVLJsGP3LWFWjCsQLAXtIWE1kd3b+bXyNWmoFbxvV0=
|
What is the use-case? |
|
It's used by kodi to verify that the mirror that it gets redirected to is delivering the expected file unaltered |
|
For reference, these are the mirrorbits changes on kodi's side, from 2018: https://github.com/xbmc/mirrorbits/pulls?q=is%3Apr+is%3Aclosed I did some research and RFC-1864 seems to be considered deprecated since HTTP/1.1 (grep for OTOH, there's this old discussion: #49 (comment), where etix discussed RFC-6249 and adding support for a It seems to me that RFC-6249 would be a better way to go. RFC names:
|
|
We do not have the option to use any different structure/headers,, since Kodi expects the Content-* headers and we cannot retro-patch every active installation out there. So at least for us, this would not be an option. We can also keep it alive in our fork if that is preferred. |
adds an rfc1864 compatible content-md5 header and analog extensions for sha1 and sha256 if the option CheckSumHeaders is true the following extra http headers will be added:
Content-Md5: I9rjdRkQr90tbzCzZtDy4A==
Content-Sha1: kvbBunf6Il0/5oMcuItvYcaHN9c=
Content-Sha256: ktVLJsGP3LWFWjCsQLAXtIWE1kd3b+bXyNWmoFbxvV0=