Fix issue #18: Handle tokens without algorithm in protected headers#52
Open
kallal79 wants to merge 1 commit intoveraison:mainfrom
Open
Fix issue #18: Handle tokens without algorithm in protected headers#52kallal79 wants to merge 1 commit intoveraison:mainfrom
kallal79 wants to merge 1 commit intoveraison:mainfrom
Conversation
…eaders - Add algorithm inference from public key type when algorithm is missing from protected headers (e.g., tokens created by compile_token) - Support ECDSA (ES256/384/512), EdDSA, and RSA (PS256) keys - Maintain backward compatibility with properly formed tokens - Add comprehensive tests for algorithm inference functionality - Export InferAlgorithmFromPublicKey for testing purposes This fixes the 'Error fetching alg' issue when verifying tokens that don't have algorithm information in their protected COSE headers. Signed-off-by: Kallal Mukherjee <ritamukherje62@gmail.com>
9d1137f to
6b048fb
Compare
Author
|
@thomas-fossati @yogeshbdeshpande @setrofim Fixes #18 by inferring alg from public key when missing in protected headers. All checks passed. Regression tests confirm compatibility. Requesting review and assignment. Happy to clarify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #18 where tokens created by compile_token or other tools without algorithm information in protected headers could not be verified.
Problem
The original Evidence.Verify() function required the algorithm to be present in the COSE protected headers. When the algorithm was missing, verification would fail with an Error fetching alg message.
Solution
Changes
Testing
Fixes #18