Update client.py for new Fern SDK signatures#61
Merged
adeelehsan merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Remove request_timeout and request_timeout_millis from convenience methods (query, query_stream, chat, chat_stream, create_chat_session) and ChatSession class. These parameters are no longer accepted by the Fern-generated SDK — timeouts are now set via request_options. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
client.pyconvenience methods to match the new Fern-generated SDK signatures.Changes
request_timeoutandrequest_timeout_millisparameters from:Vectara.query(),Vectara.query_stream()Vectara.chat(),Vectara.chat_stream()Vectara.create_chat_session()ChatSession.__init__(),ChatSession.chat(),ChatSession.chat_stream()These parameters are no longer accepted by the Fern-generated query/chat clients. Timeouts should now be set via
request_options={"timeout_in_seconds": N}.Why
The new Fern SDK (with
auth: anyconfig from docs PR #565) changed method signatures —request_timeoutandrequest_timeout_milliswere removed from all generated clients. Our customclient.pywas passing these through, causingTypeError: got an unexpected keyword argument.Tested
Full SDK test suite: 178 passed, 0 failed, 3 skipped against staging with the preview-generated SDK.
Merge order
vectara>=0.4.3🤖 Generated with Claude Code