Open
Conversation
Reviewer's Guide by SourceryThis pull request focuses on fixing typos and improving clarity across the documentation, including updates to installation instructions, explanations of versioning, and code examples. It also includes type hints to the Updated class diagram for the my_git_repo fixtureclassDiagram
class CreateRepoPytestFixtureFn {
}
class Dict~str, Any~ {
}
class Path {
}
my_git_repo -- CreateRepoPytestFixtureFn : create_git_remote_repo
my_git_repo -- Path : gitconfig
my_git_repo -- Dict~str, Any~ : git_commit_envvars
my_git_repo -- Path : return
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes look good, but it would be helpful to add a brief explanation of why
python -m pipis preferred overpip. - In
pytest-plugin.md, the code block definingmy_git_repocould benefit from a docstring explaining its purpose.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d25926b to
b12e1e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 54.09% 54.09%
=======================================
Files 40 40
Lines 3627 3627
Branches 793 793
=======================================
Hits 1962 1962
Misses 1314 1314
Partials 351 351 ☔ View full report in Codecov by Sentry. |
… and add Python syntax highlighting
…th main installation format
b12e1e2 to
ef267cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix typos and improve clarity in various documentation sections.
Documentation: