Fix set() not clearing cached instance on override#9
Merged
ChiragAgg5k merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
When calling set() to override an already-resolved dependency, the stale cached value in $concrete was still returned by get(). Now set() clears the cache entry so the new factory is used on the next get() call.
Greptile SummaryThis PR fixes a bug where calling Key changes:
Notable limitation: The fix only invalidates the cache for the directly overridden dependency. Dependents that were already resolved and cached using the old value of Confidence Score: 4/5
Important Files Changed
Last reviewed commit: "Fix set() not cleari..." |
loks0n
reviewed
Mar 20, 2026
6f6e323 to
133705f
Compare
loks0n
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set()was called to override an already-resolved dependency,get()still returned the stale cached value from$concreteunset($this->concrete[$id])inset()to clear the cache when a dependency is re-registeredtestSetOverridesCachedInstancethat resolves a dependency, overrides it viaset(), and verifies the new value is returnedTest plan