Skip to content

WIP: Function overlay#87

Open
amoisson wants to merge 17 commits into
upmem_release_120from
lld-overlay-patch
Open

WIP: Function overlay#87
amoisson wants to merge 17 commits into
upmem_release_120from
lld-overlay-patch

Conversation

@amoisson
Copy link
Copy Markdown

No description provided.

@amoisson
Copy link
Copy Markdown
Author

remove lld modifications

@wwolff42 wwolff42 self-requested a review July 31, 2024 13:58
Copy link
Copy Markdown

@wwolff42 wwolff42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend or comment back.

Comment thread lld/ELF/LinkerScript.cpp
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find another way of using and implementing OVERLAY command, please remove your change.

Comment thread lld/ELF/LinkerScript.h
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find another way of using and implementing OVERLAY command, please remove your change.

Comment thread lld/ELF/ScriptParser.cpp
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find another way of using and implementing OVERLAY command, please remove your change.

Comment thread lldb/source/Plugins/Process/Dpu/DpuContext.cpp Outdated
#include "ThreadDpu.h"

extern "C" {
#include <dpu_program.h>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readjust header includes.
have together the backends includes, (dpu_types.h above)

return &g_reg_sets_dpu;
}

Status FixPc(ProcessDpu *process, uint32_t *pc) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abuse \n :)

Comment thread lldb/source/Plugins/Process/Dpu/RegisterContextDpu.cpp Outdated
Comment thread lldb/source/Plugins/Process/Utility/UnwindDPU.cpp Outdated
Comment thread lldb/source/Plugins/Process/Utility/UnwindDPU.cpp Outdated
@@ -578,8 +585,10 @@ size_t ProcessDpu::UpdateThreads() { return m_threads.size(); }

Status ProcessDpu::SetBreakpoint(lldb::addr_t addr, uint32_t size,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does function_group feature works with breakpoint now?
No worries if not and WIP status.
if it's not working yet, maybe return a failure if we try to breakpoint in such section would make sense for now?

same apply to unwinding.
it's a very experimental feature we understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants