Skip to content

New Crowdin updates#1983

Open
elibosley wants to merge 4 commits intomainfrom
l10n_main
Open

New Crowdin updates#1983
elibosley wants to merge 4 commits intomainfrom
l10n_main

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented Apr 1, 2026

Summary by CodeRabbit

  • Localization
    • Updated Hungarian translations across the onboarding flow, covering setup messages, loading states, modal dialogs, error/status messages, and completion summaries.
    • Refined registration labels to clarify references to license-bound hardware instead of generic boot-device terminology, improving clarity during device registration.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.56%. Comparing base (160c5b1) to head (0d4c4ee).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
+ Coverage   52.21%   52.56%   +0.34%     
==========================================
  Files        1032     1033       +1     
  Lines       71646    71649       +3     
  Branches     8146     8172      +26     
==========================================
+ Hits        37412    37664     +252     
+ Misses      34109    33860     -249     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2abab144-ab66-4947-b7bb-6fde80200db7

📥 Commits

Reviewing files that changed from the base of the PR and between 806d78f and 0d4c4ee.

📒 Files selected for processing (1)
  • web/src/locales/hu.json
✅ Files skipped from review due to trivial changes (1)
  • web/src/locales/hu.json

Walkthrough

Hungarian localization strings updated across onboarding workflows and registration UI. English placeholders were replaced with Hungarian translations and registration labels changed from generic "boot device" wording to license-bound device terminology.

Changes

Cohort / File(s) Summary
Hungarian Localization Updates
web/src/locales/hu.json
Replaced multiple onboarding and loading UI strings with Hungarian translations (e.g., completion failure, loading titles/descriptions, modal closing text, plugin step descriptions, summary logs). Updated registration labels from generic "boot device"/type to license-bound device wording.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hopped through keys and strings tonight,
Swapping English for magyar delight,
Devices now bound by license and song,
Onboarding whispers soft and strong,
Carrots of code — translated just right.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'New Crowdin updates' is vague and generic, using non-descriptive language that doesn't convey specific information about the changeset. Consider using a more descriptive title that specifies the localization changes, such as 'Update Hungarian localizations for onboarding and registration' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l10n_main

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@web/src/locales/hu.json`:
- Line 116: The Hungarian message for the key
"onboarding.nextSteps.completionFailed" incorrectly uses the word
"regisztrációt" (registration); update the localized string value to refer to
onboarding instead (for example replace "regisztrációt" with "onboardolást" or a
more natural Hungarian equivalent like "a bevezetési folyamatot") so the message
shown in the onboarding completion flow uses onboarding wording.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a4808ced-f84d-41c4-ab91-e31c0e258df4

📥 Commits

Reviewing files that changed from the base of the PR and between 160c5b1 and 806d78f.

📒 Files selected for processing (1)
  • web/src/locales/hu.json

Comment thread web/src/locales/hu.json
"onboarding.nextSteps.reboot": "Újraindítás",
"onboarding.nextSteps.additionalLinks": "További hivatkozások",
"onboarding.nextSteps.completionFailed": "We couldn't finish onboarding right now. Please try again.",
"onboarding.nextSteps.completionFailed": "Jelenleg nem tudtuk befejezni a regisztrációt. Kérjük, próbálja újra.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use onboarding wording instead of registration in this error message.

Line 116 is shown in onboarding completion flow, but the Hungarian text says “regisztrációt,” which shifts meaning to registration and can confuse users.

💬 Suggested wording fix
-  "onboarding.nextSteps.completionFailed": "Jelenleg nem tudtuk befejezni a regisztrációt. Kérjük, próbálja újra.",
+  "onboarding.nextSteps.completionFailed": "Jelenleg nem tudtuk befejezni a bevezetést. Kérjük, próbálja újra.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"onboarding.nextSteps.completionFailed": "Jelenleg nem tudtuk befejezni a regisztrációt. Kérjük, próbálja újra.",
"onboarding.nextSteps.completionFailed": "Jelenleg nem tudtuk befejezni a bevezetést. Kérjük, próbálja újra.",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@web/src/locales/hu.json` at line 116, The Hungarian message for the key
"onboarding.nextSteps.completionFailed" incorrectly uses the word
"regisztrációt" (registration); update the localized string value to refer to
onboarding instead (for example replace "regisztrációt" with "onboardolást" or a
more natural Hungarian equivalent like "a bevezetési folyamatot") so the message
shown in the onboarding completion flow uses onboarding wording.

@github-actions
Copy link
Copy Markdown
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1983/dynamix.unraid.net.plg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant