fix: run blocking chardet.detect in thread executor #1751#1760
Open
nitesh-77 wants to merge 1 commit intounclecode:mainfrom
Open
fix: run blocking chardet.detect in thread executor #1751#1760nitesh-77 wants to merge 1 commit intounclecode:mainfrom
nitesh-77 wants to merge 1 commit intounclecode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1751
The Bug:
chardet.detect is CPU-bound and was blocking the main asyncio event loop in _handle_http, causing lags of 1+ seconds on large pages.
The Fix:
Wrapped the detection in asyncio.to_thread to offload it to a worker thread.
Verification:
Verified locally with a reproduction script; the event loop heartbeat remained active during detection.