Add locale-aware GlobalFontFamily and enable dynamic FontFamily#852
Draft
lindwurm wants to merge 1 commit into
Draft
Add locale-aware GlobalFontFamily and enable dynamic FontFamily#852lindwurm wants to merge 1 commit into
lindwurm wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <copilot@github.com>
Owner
|
Hi @lindwurm, thank you for looking into this, I wasn't aware that font rendering was spotty! While I understand that this PR is still a draft, I'd like to add in some context:
Thanks in advance! |
Author
Certainly this font has a narrow character width but I hadn't even considered about that.
To be honest, there isn't enough research. That's also why I've left this PR as a draft (maybe I should have created an issue first). Since the issue occurs only in certain components,
then I tried to implement that based on hypothesis like:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switched to changing the font family dynamically to use correct one.
Motivation
The language‑specific font priority isn't working in both the Media Flyout and the Taskbar Widget ("Up Next" isn't affected). As a result, characters aren't rendered using the intended fonts (In the following example, selected font is not suitable for displaying Japanese).
For Japanese users, being forced into an inappropriate fallback font significantly degrades readability and user experience — much like replacing all English text with Comic Sans🙃
The logic was in place (eg. #317 ), but it wasn’t actually taking effect in all relevant parts of the UI.
Type of Change
What Changed
GlobalFontFamilyviaApplication.Current.Resourcesso UI updates at runtimeTextBlockandControlstyles in App.xaml useDynamicResource GlobalFontFamilyfor consistent font applicationGlobalFontFamilyso icon rendering is not brokenAdditional Information
Checklist