Skip to content

Limestone rewrite#87

Open
Nealium104 wants to merge 66 commits into
mainfrom
limestone-rewrite
Open

Limestone rewrite#87
Nealium104 wants to merge 66 commits into
mainfrom
limestone-rewrite

Conversation

@Nealium104

@Nealium104 Nealium104 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

This PR covers the exploreuk-web-app side of the rewrite of ExploreUK using the University's Limestone project. Almost all functional changes are UI only.
Fixes #72, fixes #77, fixes #79, fixes #81, fixes #82, fixes #83, fixes #86, fixes #43, fixes #37, fixes #38.

Changes

  • Home page hero section - Featured image is still dynamic, but constrains height to max 55% of the viewport height. Text is always over image even in mobile
  • Global header - Integrates Nicole's changes to the header component and fixes some issues getting it to work on mobile. Add global menu #77
  • Search results - Uses Limestone's grid layout system, page split between facet options and individual results.
  • Facets - A frankenstein of Limestone's description list component, buttons, and a modal for viewing all facets.
  • Pagination - Reworked pagination component with limestone's styles. Integrates some existing functionality to add/remove items like previous next as needed in the search results. Pagination #83
  • Breadcrumbs - Extracted component. Conditionally renders "Back to search results" when needed. Breadcrumb #82
  • Item page - Uses Limestone's tabs component for the table as needed.
  • Custom CSS - Overwrites many of Limestone's styles for a particular component. Makes use of CSS's Scoped rule to avoid clashing against Limestone's styles outside of a given section of HTML. There are also additional mobile fixes in the custom css.

Limestone

Limestone aims to provide some CSS utility classes, JavaScript scripts, and some component examples that can be used with University web properties to help developers more quickly adhere to Branding Guidelines and Accessibility concerns. At this time, the latest project is only used for Drupal components, but we have built this version of ExploreUK with version 1.0.0. This repo at one time created a compiled version of assets in that repo that can be found in the patternlab artifact. There is also a Pattern Lab website that can be accessed here to view versions of the components created for Limestone. If necessary, developers can inspect the exact code we're consuming directly from the CDN, which follows the directory structure of the Patternlab Artifact.

Minor notes

Related #73.
Dead Code - search-copy.php was dead code, a copy of search-results.php.
Merge fix for the renderLink method, which was changed to accept an $options array in a previous PR to main. Updates to callers in page-title.php to match.

@Nealium104 Nealium104 marked this pull request as ready for review April 1, 2026 14:36
@Nealium104 Nealium104 requested a review from nrsa222 April 1, 2026 14:37
@Nealium104

Copy link
Copy Markdown
Contributor Author

Just a reminder that #88 is still in development. Please use docker compose down -v before bringing back up for review.

@Nealium104

Copy link
Copy Markdown
Contributor Author

The last merge introduces changes from 88. make build && make dev will ensure the container loads a fresh image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants