Sync Convex Better Auth fixes and support Better Auth 1.6.5#217
Sync Convex Better Auth fixes and support Better Auth 1.6.5#217
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Name | Type |
|---|---|
| kitcn | Minor |
| @kitcn/resend | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 165e8fb35e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 909b10b426
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 544f0a9e72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addressed: the PR now includes an updated unreleased changeset. The bot comment is stale and still reflects an earlier draft. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85d34f9f3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const where = args.where?.filter( | ||
| (w) => | ||
| w.mode !== 'insensitive' && |
There was a problem hiding this comment.
Reapply insensitive predicates after index selection
Filtering args.where with w.mode !== 'insensitive' drops case-insensitive eq/gt/gte/lt/lte clauses from index planning, but the indexed-path fallback filter in generateQuery only reapplies contains/ends_with/ne/not_in/starts_with. That means mixed queries (e.g. one indexed sensitive clause plus one mode: "insensitive" equality clause) can return rows that do not satisfy the insensitive condition, because that predicate is neither pushed down nor post-filtered. This is a correctness regression for Better Auth 1.6 Where.mode queries.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c7cc2e78a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -408,7 +427,12 @@ const filterByWhere = < | |||
| return value === w.value || isGreaterThan(value, w.value); | |||
There was a problem hiding this comment.
Normalize insensitive equality in gte/lte filters
The new case-insensitive path normalizes string comparisons, but gte/lte still use raw equality (value === w.value) before calling the normalized comparator. For mode: "insensitive", values that are equal except for casing (for example "ABC" vs "abc") fail both checks and get filtered out, which returns incorrect rows for insensitive range queries whenever this static filter path is used.
Useful? React with 👍 / 👎.
Summary
sync-convex-authaudit skill for fork/upstream review work@convex-dev/better-authto0.11.4registerRouteslazy by default and require explicitbasePathfor non-default auth routesbetter-auth@1.6.5across kitcn, example, docs, and auth fixtures1.6.xcompiles before upstream catches up1.6Where.modeBreaking changes
basePathwhen usingregisterRoutes.1.5.3to1.6.5.Notes
oidc-providerdeprecation warning through@convex-dev/better-auth@0.11.4Verification
bun test packages/kitcn/src/cli/supported-dependencies.test.ts packages/kitcn/src/cli/registry/dependencies.test.tsbun test packages/kitcn/src/auth-client/package-entrypoints.integration.test.tsx packages/kitcn/src/react/auth-mutations.test.tsxbun typecheckbun run fixtures:syncbun run fixtures:checkbun check