Replace path string literals with pre-computed hashes#490
Open
nicked wants to merge 1 commit intouber:masterfrom
Open
Replace path string literals with pre-computed hashes#490nicked wants to merge 1 commit intouber:masterfrom
nicked wants to merge 1 commit intouber:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen previously emitted full component path strings as literals (e.g.
^->AppComponent->RootComponent->...) for DI provider registration. The strings were only used as dictionary keys inproviderFactories[componentPath.hashValue]. In large apps with many components, these unique path strings can add several megabytes to the binary's__cstringsection.This change pre-computes a stable hash of each path string and emits that hash in the codegen instead. The runtime uses the same hash function to look up providers at component creation time.
Swift's
String.hashValueis non-deterministic so was replaced by a stable hashing function.