Improved error handling inside document renderer base

src/Turnierplan.App/Endpoints/Documents/GetDocumentPdfEndpoint.cs

@@ -78,8 +78,6 @@ private static async Task<IResult> Handle(
         // Wrap the code below in a transaction such that the generation count
         // is only incremented when the document is rendered successfully.
 
-        bool isSuccessful;
-
         await using (var transaction = await repository.UnitOfWork.WrapTransactionAsync())
         {
             document.IncreaseGenerationCount();
@@ -90,13 +88,11 @@ private static async Task<IResult> Handle(
             document.Tournament.ShiftToTimezone(timeZoneInfo);
             document.Tournament.Compute();
 
-            isSuccessful = renderer.Render(document.Tournament, configuration, localization, stream);
+            renderer.Render(document.Tournament, configuration, localization, stream);
 
-            transaction.ShouldCommit = isSuccessful;
+            transaction.ShouldCommit = true;
         }
 
-        return isSuccessful
-            ? Results.File(stream.ToArray(), "application/pdf")
-            : Results.InternalServerError();
+        return Results.File(stream.ToArray(), "application/pdf");
     }
 }

src/Turnierplan.PdfRendering.Test.Unit/Renderer/RendererTestBase.cs

@@ -58,9 +58,7 @@ protected void AssertRender(Tournament tournament, IDocumentConfiguration config
             __serviceProvider.GetRequiredService<ILocalizationProvider>().TryGetLocalization(languageCode, out var localization).Should().BeTrue();
 
             using var stream = new MemoryStream();
-            var isSuccessful = GetRenderer().Render(tournament, configuration, new LocalizationWrapper(localization!), stream);
-
-            isSuccessful.Should().BeTrue();
+            GetRenderer().Render(tournament, configuration, new LocalizationWrapper(localization!), stream);
 
             var pdfData = stream.ToArray();
 

src/Turnierplan.PdfRendering/Renderer/DocumentRendererBase.cs

@@ -20,7 +20,7 @@ private protected DocumentRendererBase()
 
     protected Activity? CurrentActivity { get; private set; }
 
-    public bool Render(Tournament tournament, IDocumentConfiguration configuration, ILocalization localization, Stream destination)
+    public void Render(Tournament tournament, IDocumentConfiguration configuration, ILocalization localization, Stream destination)
     {
         lock (this)
         {
@@ -53,7 +53,7 @@ public bool Render(Tournament tournament, IDocumentConfiguration configuration,
             CurrentActivity?.AddException(ex);
             CurrentActivity?.Stop();
 
-            return false;
+            throw;
         }
         finally
         {
@@ -66,8 +66,6 @@ public bool Render(Tournament tournament, IDocumentConfiguration configuration,
                 // Ignored
             }
         }
-
-        return true;
     }
 
     protected abstract Document Render(Tournament tournament, T configuration, ILocalization localization);

src/Turnierplan.PdfRendering/Renderer/IDocumentRenderer.cs

@@ -8,5 +8,5 @@ public interface IDocumentRenderer
 {
     Type DocumentConfigurationType { get; }
 
-    bool Render(Tournament tournament, IDocumentConfiguration configuration, ILocalization localization, Stream destination);
+    void Render(Tournament tournament, IDocumentConfiguration configuration, ILocalization localization, Stream destination);
 }