Skip to content

⚡ [performance] Implement bulk delete for blocks by page UUIDs #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstapler wants to merge 3 commits into
base: main
Choose a base branch
from
Open

⚡ [performance] Implement bulk delete for blocks by page UUIDs #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d39828
⚡ [performance] Implement bulk delete for blocks by page UUIDs
google-labs-jules[bot] Apr 25, 2026
5bc08a1
⚡ [performance] Implement bulk delete and fix CI failures
google-labs-jules[bot] Apr 25, 2026
455c277
⚡ [performance] Implement bulk delete and fix all PR checks
google-labs-jules[bot] Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions kmp/src/androidMain/kotlin/dev/stapler/stelekit/platform/PlatformSettings.android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ object SteleKitContext {
}
}

actual class PlatformSettings actual constructor() {
actual class PlatformSettings actual constructor() : Settings {
private val prefs: SharedPreferences by lazy {
try {
val masterKey = MasterKey.Builder(SteleKitContext.context)
Expand All @@ -36,25 +36,25 @@ actual class PlatformSettings actual constructor() {
}
}

actual fun getBoolean(key: String, defaultValue: Boolean): Boolean {
actual override fun getBoolean(key: String, defaultValue: Boolean): Boolean {
return try {
prefs.getBoolean(key, defaultValue)
} catch (e: Exception) { defaultValue }
}

actual fun putBoolean(key: String, value: Boolean) {
actual override fun putBoolean(key: String, value: Boolean) {
try {
prefs.edit().putBoolean(key, value).apply()
} catch (e: Exception) { }
}

actual fun getString(key: String, defaultValue: String): String {
actual override fun getString(key: String, defaultValue: String): String {
return try {
prefs.getString(key, defaultValue) ?: defaultValue
} catch (e: Exception) { defaultValue }
}

actual fun putString(key: String, value: String) {
actual override fun putString(key: String, value: String) {
try {
prefs.edit().putString(key, value).apply()
} catch (e: Exception) { }
Expand Down
4 changes: 4 additions & 0 deletions kmp/src/commonMain/kotlin/dev/stapler/stelekit/db/RestrictedDatabaseQueries.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ class RestrictedDatabaseQueries(private val queries: SteleDatabaseQueries) {
fun deleteBlocksByPageUuid(page_uuid: String): QueryResult<Long> =
queries.deleteBlocksByPageUuid(page_uuid)

@DirectSqlWrite
fun deleteBlocksByPageUuids(page_uuids: Collection<String>): QueryResult<Long> =
queries.deleteBlocksByPageUuids(page_uuids)

@DirectSqlWrite
fun deleteAllBlocks(): QueryResult<Long> =
queries.deleteAllBlocks()
Expand Down
4 changes: 1 addition & 3 deletions kmp/src/commonMain/kotlin/dev/stapler/stelekit/repository/SqlDelightBlockRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,9 +871,7 @@ class SqlDelightBlockRepository(
override suspend fun deleteBlocksForPages(pageUuids: List<String>): Result<Unit> = withContext(PlatformDispatcher.DB) {
if (pageUuids.isEmpty()) return@withContext success(Unit)
try {
queries.transaction {
pageUuids.forEach { queries.deleteBlocksByPageUuid(it) }
}
queries.deleteBlocksByPageUuids(pageUuids)
success(Unit)
} catch (e: Exception) {
Result.failure(e)
Expand Down
3 changes: 3 additions & 0 deletions kmp/src/commonMain/sqldelight/dev/stapler/stelekit/db/SteleDatabase.sq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@ DELETE FROM blocks;
deleteBlocksByPageUuid:
DELETE FROM blocks WHERE page_uuid = ?;

deleteBlocksByPageUuids:
DELETE FROM blocks WHERE page_uuid IN ?;

insertBlock:
INSERT OR REPLACE INTO blocks (uuid, page_uuid, parent_uuid, left_uuid, content, level, position, created_at, updated_at, properties, version, content_hash, block_type)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);
Expand Down
5 changes: 1 addition & 4 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/BottomNavScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
package dev.stapler.stelekit.ui
import androidx.compose.ui.test.*

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
Expand All @@ -16,10 +17,6 @@ import androidx.compose.material3.Text
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clipToBounds
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.onRoot
import dev.stapler.stelekit.ui.theme.StelekitTheme
import dev.stapler.stelekit.ui.theme.StelekitThemeMode
import io.github.takahirom.roborazzi.captureRoboImage
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/ComposeUITestBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package dev.stapler.stelekit.ui

import androidx.compose.ui.test.junit4.ComposeTestRule
import androidx.compose.ui.test.junit4.createComposeRule
import dev.stapler.stelekit.db.GraphLoader
import dev.stapler.stelekit.db.GraphWriter
Expand Down
6 changes: 1 addition & 5 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/MigrationReadyLoadingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
package dev.stapler.stelekit.ui
import androidx.compose.ui.test.*

import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
Expand All @@ -7,11 +8,6 @@ import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertDoesNotExist
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onNodeWithText
import kotlinx.coroutines.delay
import org.junit.Rule
import org.junit.Test
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/VoiceCaptureButtonScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-License-Identifier: Elastic-2.0
package dev.stapler.stelekit.ui

import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onRoot
import dev.stapler.stelekit.ui.components.VoiceCaptureButton
import dev.stapler.stelekit.ui.theme.StelekitTheme
Expand Down
5 changes: 1 addition & 4 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/components/SearchDialogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
package dev.stapler.stelekit.ui.components
import androidx.compose.ui.test.*

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performTextInput
import dev.stapler.stelekit.repository.InMemorySearchRepository
import dev.stapler.stelekit.ui.fixtures.PopulatedFakePageRepository
import dev.stapler.stelekit.ui.fixtures.PopulatedFakeBlockRepository
Expand Down
5 changes: 1 addition & 4 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/components/SuggestionContextMenuTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
package dev.stapler.stelekit.ui.components
import androidx.compose.ui.test.*

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import org.junit.Rule
import org.junit.Test
import kotlin.test.assertTrue
Expand Down
7 changes: 1 addition & 6 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/components/SuggestionNavigatorPanelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
package dev.stapler.stelekit.ui.components
import androidx.compose.ui.test.*

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertIsEnabled
import androidx.compose.ui.test.assertIsNotEnabled
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import org.junit.Rule
import org.junit.Test
import kotlin.test.assertEquals
Expand Down
2 changes: 0 additions & 2 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/components/SuggestionRenderBenchmarkTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.setValue
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onNodeWithText
import dev.stapler.stelekit.domain.AhoCorasickMatcher
import dev.stapler.stelekit.ui.theme.StelekitTheme
Expand Down
4 changes: 0 additions & 4 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/components/TopBarTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ package dev.stapler.stelekit.ui.components

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithContentDescription
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import dev.stapler.stelekit.ui.fixtures.InMemorySettings
import dev.stapler.stelekit.ui.AppState
Expand Down
2 changes: 1 addition & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/fixtures/FakeRepositories.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class InMemorySettings : Settings {
}
}

class FakeFileSystem : FileSystem {
open class FakeFileSystem : FileSystem {
override fun getDefaultGraphPath(): String = "/tmp/graph"
override fun expandTilde(path: String) = path
override fun readFile(path: String): String? = ""
Expand Down
3 changes: 0 additions & 3 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/layout/DesktopLayoutTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ package dev.stapler.stelekit.ui.layout

import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.onNodeWithText
import dev.stapler.stelekit.ui.MainLayout
import org.junit.Rule
Expand Down
4 changes: 1 addition & 3 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/layout/MobileLayoutTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package dev.stapler.stelekit.ui.layout
import androidx.compose.ui.test.*

import androidx.compose.foundation.layout.Box
import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clipToBounds
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.unit.dp
import dev.stapler.stelekit.ui.components.LeftSidebar
import dev.stapler.stelekit.ui.AppState
Expand Down
6 changes: 1 addition & 5 deletions kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/layout/SidebarLoadingStateTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
package dev.stapler.stelekit.ui.layout
import androidx.compose.ui.test.*

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertIsNotDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import dev.stapler.stelekit.model.Page
import dev.stapler.stelekit.ui.Screen
import dev.stapler.stelekit.ui.components.LeftSidebar
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/screens/JournalsViewSqlDelightTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package dev.stapler.stelekit.ui.screens

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import dev.stapler.stelekit.db.DriverFactory
import dev.stapler.stelekit.db.GraphLoader
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/screens/JournalsViewUITest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package dev.stapler.stelekit.ui.screens

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import dev.stapler.stelekit.db.GraphLoader
import dev.stapler.stelekit.repository.JournalService
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/screens/PageViewUITest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package dev.stapler.stelekit.ui.screens

import androidx.compose.material3.MaterialTheme
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import dev.stapler.stelekit.db.GraphLoader
import dev.stapler.stelekit.db.GraphWriter
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/screenshots/DemoGraphScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package dev.stapler.stelekit.ui.screenshots

import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onRoot
import io.github.takahirom.roborazzi.captureRoboImage
import dev.stapler.stelekit.db.GraphLoader
Expand Down
1 change: 0 additions & 1 deletion kmp/src/jvmTest/kotlin/dev/stapler/stelekit/ui/screenshots/JournalsViewScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package dev.stapler.stelekit.ui.screenshots

import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onRoot
import io.github.takahirom.roborazzi.captureRoboImage
import dev.stapler.stelekit.db.DriverFactory
Expand Down