Add support for gitlab project with groups#176
Open
refactorraccoon wants to merge 1 commit intotsoding:masterfrom
Open
Add support for gitlab project with groups#176refactorraccoon wants to merge 1 commit intotsoding:masterfrom
refactorraccoon wants to merge 1 commit intotsoding:masterfrom
Conversation
rexim
requested changes
Feb 28, 2020
Member
There was a problem hiding this comment.
Hello @antonyhell! Thank you very much for the contribution!
I have no idea what GitLab groups are since I don't use GitLab, but if it's something that you need support for I'm ok with that. This regex change looks a little bit scary to me since I have no idea if it breaks any existing GitLab functionality. Could we please have a couple of very simple unit test cases with and without GitLab groups? Nothing fancy. Just something simple and quick to sanity check the changes.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.