Fix last keystroke time not being updated on certain keys#76
Open
mjkloeckner wants to merge 3 commits intotsoding:masterfrom
Open
Fix last keystroke time not being updated on certain keys#76mjkloeckner wants to merge 3 commits intotsoding:masterfrom
mjkloeckner wants to merge 3 commits intotsoding:masterfrom
Conversation
I noticed that while pressing tab the cursor last keystroke was not
being updated:
```c
for (size_t i = 0; i < 4; ++i) {
editor_insert_char(&editor, ' ');
}
```
it should be:
```c
for (size_t i = 0; i < 4; ++i) {
editor_insert_char(&editor, ' ');
}
editor.last_stroke = SDL_GetTicks();
```
but instead of updating the last keystroke individualy in every
keypress, it's better to update it when a key is pressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that while pressing tab the cursor last keystroke was not being updated:
it should be:
but instead of updating the last keystroke individually in every key press, it's better to update it when a key is pressed regardless if the key being pressed has a dedicated function or not.
This commit removes all the
editor.last_stroke = SDL_GetTicks();from every key case and adds only one after theswitchexecution.