Declare fragment shader outputs, improving compatibility (macOS)#75
Open
fabjan wants to merge 1 commit intotsoding:masterfrom
Open
Declare fragment shader outputs, improving compatibility (macOS)#75fabjan wants to merge 1 commit intotsoding:masterfrom
fabjan wants to merge 1 commit intotsoding:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build went fine without warnings or errors on my Mac, but the shaders cannot be compiled:
Is the program written for a different GL version than what macOS 11.7.2 provides perhaps (see caveats)?
Solution
Update each of the
shaders/simple_*.fragprograms to stop usinggl_FragColor, instead declareout vec4 fragColor;and use that.Fixes #65.
Compare for this fix in dlangui:
buggins/dlangui@6cfe98a#diff-0671d7c48bc6543434a3b3c9b6671be5b41902e679cfa0520fa7f0c780d670e4L231
Caveats
I don't write many graphical programs. Perhaps macOS is always a pain and you don't want to support it. Given that build.sh contains a uname check for "Darwin" though, I'm giving it a shot.
I used the following versions of the dependencies (latest in Homebrew):