feat: specialized horizontal row layout for decoupling capacitor partitions#90
Open
adminlmz wants to merge 1 commit into
Open
feat: specialized horizontal row layout for decoupling capacitor partitions#90adminlmz wants to merge 1 commit into
adminlmz wants to merge 1 commit into
Conversation
…itions When SingleInnerPartitionPackingSolver encounters a partition with partitionType === "decoupling_caps", bypass PackSolver2 and arrange caps in a clean horizontal row instead. Changes: - Added createDecouplingCapLayout() method - Caps are placed in a single row with consistent 0° rotation - Even spacing using decouplingCapsGap (default 0.5) - Centered around origin for clean alignment - General partitions still use PackSolver2 as before Closes tscircuit#15
|
@adminlmz is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
SingleInnerPartitionPackingSolverencounters a partition withpartitionType === "decoupling_caps", this PR bypassesPackSolver2and arranges capacitors in a clean horizontal row instead.Changes
createDecouplingCapLayout()method toSingleInnerPartitionPackingSolverdecouplingCapsGap(default 0.5mm)PackSolver2as before — no behavior change for non-decoupling partitionsWhy this approach
The existing
IdentifyDecouplingCapsSolveralready identifies decoupling cap groups, andChipPartitionsSolveralready creates separate partitions withpartitionType: "decoupling_caps". The missing piece was specialized packing logic for these partitions.A horizontal row layout is the industry-standard approach for decoupling capacitors:
Testing
LayoutPipelineSolver03test (chip with multiple capacitors) passes successfullyRelated
Closes #15
/claim #15