[codex] Add deterministic decoupling cap row layout#86
Open
dclawd88 wants to merge 2 commits into
Open
Conversation
|
Someone is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Status note: test, format-check, and type-check are green. The remaining red status is the Vercel deployment authorization gate that requires a tscircuit team member to authorize the fork deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claim #15
partitionType === "decoupling_caps".decouplingCapsGapwith achipGapfallback, and account for fixed 90/270 degree rotations when calculating row width.Why
The pipeline already identifies decoupling capacitor groups and separates them into
decoupling_capspartitions, but those partitions still went throughPackSolver2. That generic packing can produce cluttered decap clusters. A narrow deterministic row path makes the decoupling-cap case predictable without changing default partition behavior.Validation
npx --yes bun test tests/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.test.tsnpx --yes bun run format:checknpx --yes bun run buildgit diff --checkI also ran
npx --yes bun test; the suite reached 20 passing tests and 1 skipped test, then stopped on an existing dependency export issue:convertCircuitJsonToSchematicSimulationSvgis not exported fromcircuit-to-svg/dist/index.js.