You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add a dedicated fast path for decoupling_caps partitions in SingleInnerPartitionPackingSolver
place decoupling capacitors in a deterministic, naturally sorted, centered row using decouplingCapsGap ?? chipGap
preserve allowed rotations and normalize positive-voltage pins toward y+ when a 0/180 rotation choice is available
add focused regression coverage for row placement, natural ordering, spacing, and rotation normalization
Verification
npx --yes bun@latest test tests/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.test.ts
npx --yes bun@latest run build
npx --yes bun@latest run format:check
git diff --check
Note: npx --yes bun@latest test still has unrelated baseline failures in the JSX/circuit dependency path and a circuit-to-svg export mismatch; the new focused tests pass.
CI is now green on the latest commit (test, format-check, and type-check pass). The only remaining failing status is Vercel, which reports Authorization required to deploy; that needs approval from a tscircuit Vercel team member.
It shows the new deterministic cap-only row layout, natural chip ordering, centered placement, VDD/GND pin orientation behavior, and the passing verification coverage.
Heads-up: the only remaining failing status is Vercel (Authorization required to deploy). If a tscircuit Vercel team member can authorize the deployment for this PR, all checks should be green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decoupling_capspartitions inSingleInnerPartitionPackingSolverdecouplingCapsGap ?? chipGapy+when a 0/180 rotation choice is availableVerification
npx --yes bun@latest test tests/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.test.tsnpx --yes bun@latest run buildnpx --yes bun@latest run format:checkgit diff --checkNote:
npx --yes bun@latest teststill has unrelated baseline failures in the JSX/circuit dependency path and acircuit-to-svgexport mismatch; the new focused tests pass./claim #15