Skip to content

Add deterministic decoupling cap row layout#83

Open
Dewaldnel11 wants to merge 2 commits into
tscircuit:mainfrom
Dewaldnel11:add-decap-row-layout
Open

Add deterministic decoupling cap row layout#83
Dewaldnel11 wants to merge 2 commits into
tscircuit:mainfrom
Dewaldnel11:add-decap-row-layout

Conversation

@Dewaldnel11
Copy link
Copy Markdown

Summary

  • add a dedicated fast path for decoupling_caps partitions in SingleInnerPartitionPackingSolver
  • place decoupling capacitors in a deterministic, naturally sorted, centered row using decouplingCapsGap ?? chipGap
  • preserve allowed rotations and normalize positive-voltage pins toward y+ when a 0/180 rotation choice is available
  • add focused regression coverage for row placement, natural ordering, spacing, and rotation normalization

Verification

  • npx --yes bun@latest test tests/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.test.ts
  • npx --yes bun@latest run build
  • npx --yes bun@latest run format:check
  • git diff --check

Note: npx --yes bun@latest test still has unrelated baseline failures in the JSX/circuit dependency path and a circuit-to-svg export mismatch; the new focused tests pass.

/claim #15

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

@Dewaldnel11 is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

@Dewaldnel11
Copy link
Copy Markdown
Author

CI is now green on the latest commit (test, format-check, and type-check pass). The only remaining failing status is Vercel, which reports Authorization required to deploy; that needs approval from a tscircuit Vercel team member.

@Dewaldnel11
Copy link
Copy Markdown
Author

Demo video for the decoupling-cap layout change:

https://raw.githubusercontent.com/Dewaldnel11/matchpack/demo-assets/demo/matchpack-83-decap-row-layout-demo.mp4

It shows the new deterministic cap-only row layout, natural chip ordering, centered placement, VDD/GND pin orientation behavior, and the passing verification coverage.

Copy link
Copy Markdown
Author

Heads-up: the only remaining failing status is Vercel (Authorization required to deploy). If a tscircuit Vercel team member can authorize the deployment for this PR, all checks should be green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant