Extract CAD models from library footprint circuit json#2306
Merged
techmannih merged 1 commit intoMay 17, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
techmannih
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 941309cec6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seveibar
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cadModelfrom asyncfootprintLibraryMapcircuit json when the resolver does not return an explicitcadModeljlcpcb:library footprint that embeds CAD data in fetched circuit jsonWhy
jlcpcb:footprint resolvers can return full circuit json that already includes acad_component. Before this change, the generic library-footprint path only usedresult.cadModel, so embedded CAD metadata was dropped and the 3D render path could fall back incorrectly.Impact
Library footprint resolvers can now behave more like the
jlcpcbpath ineval: if the fetched footprint circuit json already contains CAD metadata,corewill preserve it for 3D rendering even without an explicitcadModelfield.Validation
bun test tests/footprint/footprint-library-map-jlcpcb-cadmodel.test.tsx tests/footprint/footprint-library-map-cadmodel.test.tsxbunx tsc --noEmit(fails in unrelated existing files such as schematic trace solver, pcb trace typing, and missing optional test deps)