Conversation
…abled instead of a false permission finding Customer saw 4 'Could not verify Cloud SQL SSL: <project>' findings on Google sample/AI projects (gen-lang-client-*, deploy-example-*) telling them to 'Grant cloudsql.instances.list'. Those projects simply don't use Cloud SQL — the Cloud SQL Admin API is disabled, which Google returns as HTTP 403 reason SERVICE_DISABLED, so toHttpReadFailure classified it as a permission denial and emitted a misleading medium finding. A project that hasn't enabled the API has no resources of that type to evaluate, so the per-project GCP checks (cloud-sql-ssl, cloud-sql-backups, vpc-open-firewalls, storage-public-access) now skip it — like a project with zero resources — when isGcpApiDisabled() matches Google's specific SERVICE_DISABLED signature. A genuine PERMISSION_DENIED (API enabled, role missing) still surfaces as a finding. Detection is narrow to avoid hiding real coverage gaps. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fix(integration-platform): skip GCP projects whose service API is disabled (false 'grant permission' findings)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
🎉 This PR is included in version 3.78.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Skip GCP projects with disabled service APIs in
integration-platformchecks to prevent false “grant permission” findings. This stops misleading “Could not verify…” alerts while still surfacing real permission gaps.isGcpApiDisabledto detect 403SERVICE_DISABLEDand “has not been used… or it is disabled” responses.cloud-sql-ssl,cloud-sql-backups,vpc-open-firewalls, andstorage-public-accessto skip such projects like zero-resource cases.PERMISSION_DENIEDstill reports a finding.Written for commit 535844c. Summary will update on new commits.