Skip to content

[comp] Production Deploy#3071

Merged
tofikwest merged 3 commits into
releasefrom
main
Jun 9, 2026
Merged

[comp] Production Deploy#3071
tofikwest merged 3 commits into
releasefrom
main

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Fixes the policy editor showing published content when opening a draft via Versions > Edit. The editor now loads the selected draft’s content on mount, so saved edits appear and aren’t accidentally overwritten.

  • Bug Fixes
    • Seed initial editor content from the version matching initialVersionId using resolveInitialPolicyContent.
    • Fall back to published content only when no version is selected; handle single-node vs array content and respect empty drafts.
    • Added unit tests for resolve behavior and edge cases.

Written for commit 1dc92ea. Summary will update on new commits.

Review in cubic

github-actions Bot and others added 3 commits June 9, 2026 21:08
Creating a new policy version, editing the text (which correctly saves to the
draft version), switching tabs, then opening that draft via Versions > Edit
showed the PUBLISHED version's content instead of the draft's saved edits — so
the change appeared to vanish, and a follow-up edit could overwrite the draft.

Root cause (PolicyContentManager): currentContent is seeded from the
policyContent prop, which PolicyPageTabs always sets to the published/current
version's content. The effect that swaps in the selected version's content
early-returns on first mount because prevInitialVersionIdRef is initialized to
initialVersionId. Switching tabs unmounts the Content tab (DS Tabs don't keep
inactive panels mounted), so opening a draft from the Versions tab remounts it
fresh with a versionId already in the URL and hits that skip-on-mount path.

Fix: seed currentContent from the initialVersionId version when present, via a
new pure, unit-tested helper (resolveInitialPolicyContent). viewingVersion was
already correct; this aligns the displayed content with the selected version.
No save-path change — edits were already persisting correctly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…t-load

fix(policies): show a draft version's own content when editing it
@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Building Building Jun 9, 2026 10:13pm
comp-framework-editor (staging) Ready Ready Preview, Comment Jun 9, 2026 10:13pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal (staging) Skipped Skipped Jun 9, 2026 10:13pm

Request Review

@tofikwest tofikwest merged commit a9f4267 into release Jun 9, 2026
11 of 12 checks passed
@claudfuen

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.74.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants