fix(people): respect "Send portal invite email" opt-out when adding users

[tofikwest]

Bug

On the People page, adding a user via + Add User and unchecking "Send portal invite email" still emailed the new user. The checkbox appeared to have no effect.

Root cause

The frontend (InviteMembersModal) and the API DTO both pass sendPortalEmail through correctly. The defect is in apps/api/src/people/people-invite.service.ts → addEmployeeWithoutInvite() (the path taken for strictly-employee roles, i.e. the common People-page case):

if (sendPortalEmail) {
  /* InvitePortalEmail */          // checked  → portal email ✅
} else {
  const inviteLink = this.buildPortalUrl(organizationId);
  await triggerEmail({ ..., react: InviteEmail({ organizationName, inviteLink }) }); // UNCHECKED → STILL EMAILS ❌
}

The checkbox wasn't ignored — the else branch was written to send a different email (an InviteEmail containing a portal link) instead of no email. A method named addEmployeeWithoutInvite always sent an invite.

Fix

• Send the portal invite email only when requested. When opted out, the member is added silently with no email.
• The caller no longer surfaces emailSent for an intentional skip, so the modal's "invite email could not be sent" warning (which keys off emailSent === false) doesn't fire when the admin deliberately suppressed the email.

Non-employee invites (admin/auditor/etc.) are unchanged — they still receive the app invitation needed to accept and join; the "Send portal invite email" toggle only governs the portal email.

Tests

apps/api → npx jest src/people/people-invite.service.spec.ts → 19 passed.

• Added a regression test: employee + portal unchecked → member created, no email of any kind sent, no false emailSent signal.
• Updated two existing specs that asserted the old always-send behavior.

Notes for reviewer

• Scope is intentionally minimal: 2 files (people-invite.service.ts + its spec).
• npx turbo run typecheck --filter=@trycompai/api surfaces pre-existing errors in unrelated specs (variables.controller, sync-gws.controller, risks, timelines, training, offboarding) — none in people, none introduced by this PR. Left untouched to keep the fix focused.

🤖 Generated with Claude Code

---

Summary by cubic

Fixes the People page flow so unchecking "Send portal invite email" adds the user without emailing them. Also prevents the modal from showing a false "invite email could not be sent" warning when the admin opts out.

• Bug Fixes
  • Only send the portal invite when sendPortalEmail === true; unchecked adds the member silently.
  • Return emailSent only when an email send was attempted to avoid false modal warnings.
  • Added a regression test and updated two specs to cover the opt-out path.

^{Written for commit 18144fd. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
comp-framework-editor	Ready	Preview, Comment	Jun 9, 2026 8:39pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
app	Skipped		Jun 9, 2026 8:39pm
portal	Skipped		Jun 9, 2026 8:39pm

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[claudfuen]

🎉 This PR is included in version 3.74.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀