Skip to content

fix(decoder): reject negative array lengths in parse_header #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamison wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(decoder): reject negative array lengths in parse_header #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/toon_format/decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,15 @@ def parse_header(
delimiter = COMMA
length_str = bracket_content[:-1]

# Parse length
# Parse length - reject non-integer strings (negative values are invalid)
try:
length = int(length_str)
except ValueError:
return None

if length < 0:
return None

# Check for fields segment
fields = None
after_bracket = line[bracket_end + 1 :].strip()
Expand Down