Refactor Build Process: Use pokesprite as submodule#88
Merged
Conversation
- it causes the image to be pretty big - can use the submodule dir instead - alter the makefile task to use the new script
- use 1 worker per core - add better error detection and logging for conversions
- use a tmp dir for this
- use user u instead of root
- build cows - mount cows when building assets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR moves the pokesprite repository and cowfile generation out of the Dockerfile to a git submodule and build script, which significantly improves the speed and error handling of the cowfile generation process.
Changes
Cowfiles build in parallel outside Dockerfile
Improved error handling, Better file management and user permissions
Updated github workflow