fix: double hard-reset for USB devices on Windows#30
Merged
deadprogram merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
deadprogram
force-pushed
the
windows-restart
branch
4 times, most recently
from
4f3cf80 to
8cc15f9
Compare
On Windows, a single RTS toggle via the serial library is not sufficient to reset USB CDC devices (e.g. ESP32-S3 USB-JTAG/Serial). Performing two hard-resets in sequence (non-USB timing then USB timing) reliably triggers the chip to restart. Add platform-specific hardResetUSB: on Windows it performs the double reset; on Linux/macOS it delegates to the standard hardReset with USB timing which already works correctly.
deadprogram
force-pushed
the
windows-restart
branch
from
d5446e2 to
3c01930
Compare
deadprogram
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a single RTS toggle via the serial library is not sufficient to reset USB CDC devices (e.g. ESP32-S3 USB-JTAG/Serial). Performing two hard-resets in sequence (non-USB timing then USB timing) reliably triggers the chip to restart.
Add platform-specific hardResetUSB: on Windows it performs the double reset; on Linux/macOS it delegates to the standard hardReset with USB timing which already works correctly.
Also remove unused isNativeUSBPort function.