Skip to content

Fix WebSocket subscription tracking #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zen0x7 wants to merge 1 commit into from
Closed

Fix WebSocket subscription tracking #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion server/plugins/ws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default defineNitroPlugin((nitroApp) => {
console.log('Nitro plugin [Server]')
const services = getServices();

const subscriptions = new Map<string, Set<WebSocket>>() // canal -> conexiones
const subscriptions = new Map<string, Set<WebSocket>>() // channel -> sockets

wss.on('connection', (socket) => {
let currentChannel: string | null = null
Expand Down Expand Up @@ -39,6 +39,13 @@ export default defineNitroPlugin((nitroApp) => {
callback: callback,
})) as StatusResponse;

if (response.success) {
if (!subscriptions.has(currentChannel)) {
subscriptions.set(currentChannel, new Set());
}
subscriptions.get(currentChannel)!.add(socket);
}

socket.send(JSON.stringify({
event: "SYSTEM",
success: response.success,
Expand All @@ -52,6 +59,15 @@ export default defineNitroPlugin((nitroApp) => {
type: RequestType.Unsubscribe,
channel: currentChannel!,
})) as StatusResponse;

if (currentChannel) {
const clients = subscriptions.get(currentChannel);
clients?.delete(socket);
if (clients && clients.size === 0) {
subscriptions.delete(currentChannel);
}
}

socket.send(JSON.stringify({
event: "SYSTEM",
success: response.success,
Expand All @@ -60,6 +76,13 @@ export default defineNitroPlugin((nitroApp) => {
})

socket.on('close', () => {
if (currentChannel) {
const clients = subscriptions.get(currentChannel)
clients?.delete(socket)
if (clients && clients.size === 0) {
subscriptions.delete(currentChannel)
}
}
})
})

Expand Down