Skip to content

🎨 Palette: [a11y] Add aria-labels to code block icon buttons#18

Open
threehymns wants to merge 1 commit into
masterfrom
palette/code-block-a11y-18040362900088895260
Open

🎨 Palette: [a11y] Add aria-labels to code block icon buttons#18
threehymns wants to merge 1 commit into
masterfrom
palette/code-block-a11y-18040362900088895260

Conversation

@threehymns
Copy link
Copy Markdown
Owner

💡 What: Added aria-labels to the "Select language", "Toggle line wrap", and "Copy code" buttons in the code block component.
🎯 Why: These buttons previously only had icons (and sometimes a title), which is insufficient for screen readers. Providing an explicit aria-label ensures keyboard and assistive tech users know what the buttons do.
♿ Accessibility: Improved screen reader announcements for the code block interactive controls.

(Also added a quick journal entry about looking out for missing aria-labels on icon-only buttons as learned from this exercise).


PR created automatically by Jules for task 18040362900088895260 started by @threehymns

💡 What: Added `aria-label`s to the "Select language", "Toggle line wrap", and "Copy code" buttons in the code block component.
🎯 Why: These buttons previously only had icons (and sometimes a `title`), which is insufficient for screen readers. Providing an explicit `aria-label` ensures keyboard and assistive tech users know what the buttons do.
♿ Accessibility: Improved screen reader announcements for the code block interactive controls.

Co-authored-by: threehymns <70611435+threehymns@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant