Skip to content

🎨 Palette: Add ARIA labels to icon-only buttons#16

Open
threehymns wants to merge 1 commit into
masterfrom
palette-aria-labels-12345375743039040404
Open

🎨 Palette: Add ARIA labels to icon-only buttons#16
threehymns wants to merge 1 commit into
masterfrom
palette-aria-labels-12345375743039040404

Conversation

@threehymns
Copy link
Copy Markdown
Owner

💡 What

Added missing aria-label attributes alongside title attributes to various icon-only buttons throughout the application.

🎯 Why

When building UI with icon-only buttons (e.g., using HugeiconsIcon), the presence of a title attribute provides a helpful tooltip on hover, but it is often insufficient for comprehensive accessibility. Screen readers require explicit aria-label attributes to reliably announce the purpose of these interactive elements. This change makes the application significantly more accessible.

♿ Accessibility

  • Fixed missing labels on Settings page 'Go back' button.
  • Fixed missing labels on Code Block language selector, line wrap toggle, and copy buttons.
  • Fixed missing labels on Frontmatter property deletion and type selection buttons.
  • Fixed missing labels on Graph Tab panel reset and close buttons.
  • Added a new journal entry documenting the importance of aria-labels for icon-only buttons.

PR created automatically by Jules for task 12345375743039040404 started by @threehymns

- Add descriptive aria-label and title attributes to multiple icon-only buttons across the app
- Ensure settings page back button, code block controls, frontmatter editor actions, and graph tab buttons are accessible
- Address the accessibility gap where a title attribute alone is insufficient for screen readers
- Document learning regarding icon-only button accessibility in the Palette journal

Co-authored-by: threehymns <70611435+threehymns@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant