Skip to content

🎨 Palette: Frontmatter Editor Accessibility enhancements#12

Open
threehymns wants to merge 1 commit into
masterfrom
feat/a11y-frontmatter-editor-640626950116412853
Open

🎨 Palette: Frontmatter Editor Accessibility enhancements#12
threehymns wants to merge 1 commit into
masterfrom
feat/a11y-frontmatter-editor-640626950116412853

Conversation

@threehymns
Copy link
Copy Markdown
Owner

Palette: UX improvements to the Frontmatter Editor

💡 What:

  • Added aria-labels to dynamically generated property keys and inputs.
  • Wrapped the icon-only "remove property" button in a Tooltip and supplied an aria-label.
  • Added the asChild prop to TooltipTrigger and PopoverTrigger components that were wrapping Button components to resolve nested button HTML validation issues.

🎯 Why:
To make the frontmatter editor more accessible for screen reader users and prevent hydration errors / invalid HTML nesting within Radix UI components.

♿ Accessibility:
Improved keyboard accessibility and screen reader support through descriptive ARIA labels. Fixed button-within-button anti-pattern.


PR created automatically by Jules for task 640626950116412853 started by @threehymns

Co-authored-by: threehymns <70611435+threehymns@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant