Upgrade golang to 1.26, and please plugins to latest

[SpangleLabs]

Mostly, I want the updated version of go-rules, for #3497 , but let's upgrade the others too.

Go rules: v1.21.5 -> v1.29.0
Shell rules: v0.1.1 -> v0.2.1
Python rules: v1.7.4 -> v1.14.0

I held off on upgrading python rules plugin to v2
And the cc-rules plugin is already up to date

And upgrading golang from v1.24.10 to v1.26.1

[SpangleLabs]

Dang it, I've bisected various changes and the remaining test failure is due to upgrading go-rules from v1.22.0 to v1.23.0, which was a version released by me 1 year ago. I guess we didn't spot this failure back then... Perhaps we should be updating our plugins more frequently

[SpangleLabs]

Other things took priority, and now I'm struggling to remember where I was with this 😢

So, the failing test is effectively running plz cover on a plz e2e test which is running plz test, and then somehow the plz test being run ends up thinking it's a plz cover, but lacks the coverage file, and fails to set things up here:
https://github.com/please-build/go-rules/blob/165de83303a1604e48df6a998e61fca175b7273e/build_defs/go.build_defs#L859-L865

I can reproduce the failure locally by running:

plz clean && plz build //src:please && plz-out/bin/src/please cover --nocoverage_report //test:extra_test_output_test -c cover -v warn

My investigations a couple weeks ago found I could fix this by always setting the COVERAGE_FILE env variable, outside the check for whether something needs coverage, here:

please/src/core/build_env.go

Line 175 in 4fec6ab

env["COVERAGE_FILE"] = filepath.Join(testDir, CoverageFile)

Or by removing the state.NeedCoverage check from BuildTarget.NeedCoverage() here:

please/src/core/build_target.go

Line 1971 in c3c0cc9

return state.NeedCoverage && !target.Test.NoOutput && !target.Test.NoCoverage && !target.HasAnyLabel(state.Config.Test.DisableCoverage)

But I'm not too sure the expectation of the test, here:

please/test/BUILD

Line 263 in 1796f69

cmd = "plz test //test:extra_test_output_go_test",

Which runs plz test, but in the build-linux-alt CICD job, we're defining PLZ_COVER here:

please/.circleci/config.yml

Line 98 in 624a917

PLZ_COVER: "cover --nocoverage_report"

in order to make it run the e2e test itself with plz cover, via the logic here:

please/test.sh

Line 48 in 3997e56

plz-out/bin/src/please -p -v2 $PLZ_ARGS ${PLZ_COVER:-test} $EXCLUDES --include=e2e --log_file plz-out/log/e2e_build.log --log_file_level 4 $@

So, I guess the actual issue is not the lack of COVERAGE_FILE, but actually the fact that the plz binary under test thinks it's running cover, rather than test? I'm not certain

[SpangleLabs]

So, I'm left wondering what plz test -c cover is meant to actually do. It doesn't mark something as needing coverage, so it doesn't entirely do what the tests seem to indicate they want to do.

If we swapped this line:

please/src/please.go

Line 1152 in c388f68

state.NeedCoverage = opts.Cover.active

to be:

state.NeedCoverage = opts.Cover.active || config.Build.Config == "cover"

Then that might fix it, but I'm still not sure of the original intents here

[SpangleLabs]

I'm testing this now against our code base with #3519 applied also. If it works, I'll get this PR split up into parts, and get the parts reviewed

[SpangleLabs]

Rebased to remove the lint fixes which went into #3522

[SpangleLabs]

Rebased onto master after that landed